std: sysstr refactor
#25185
Merged
std: sysstr refactor
#25185
+54
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of nim-lang#25180. This one refactors the sequence routines. Preparation for extending with new routines. Mostly removes repeating code to simplify debugging. Removes: - `incrSeqV2` superseded by `incrSeqV3`, - `setLengthSeq` superseded by `setLengthSeqV2` Note comment on line 338, acknowledging that implementation of `setLenUninit` from nim-lang#25022 does zero the new memory in this branch, having been copied from `setLengthSeqV2`. This PR does not fix this.
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Contributor
|
ping @narimiran backport pls |
Member
When trying to backport, there are merge conflicts due to the fact that the following PRs haven't been backported:
...which both have their own merge conflicts. Is the reward:risk ratio high enough? |
Contributor
yeah, all of them are high value (just for 2.2 - 2.0 not needed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #25180. This one refactors the sequence routines.
Preparation for extending with new routines.
Mostly removes repeating code to simplify debugging.
Removes:
incrSeqV2superseded byincrSeqV3,setLengthSeqsuperseded bysetLengthSeqV2Note comment on line 338, acknowledging that implementation of
setLenUninitfrom #25022 does zero the new memory in this branch, having been copied fromsetLengthSeqV2. This PR does not fix this.